Skip to content

fix(customeradministration): enhance attribute coverage of queries/mutations#1347

Merged
pranav-new-relic merged 3 commits intomainfrom
customeradministration-organization-pkgs-upgrades
Nov 21, 2025
Merged

fix(customeradministration): enhance attribute coverage of queries/mutations#1347
pranav-new-relic merged 3 commits intomainfrom
customeradministration-organization-pkgs-upgrades

Conversation

@pranav-new-relic
Copy link
Member

@pranav-new-relic pranav-new-relic commented Nov 18, 2025

Enhances attribute coverage for customer administration and organization management APIs with comprehensive type definitions, query support, and field corrections.

Organization Package

  • Renamed OrganizationOrganizationManagement for clarity between data types and API client
  • Added GetOrganization() query returning organization details (administrator, customerId, telemetryId, etc.)
  • Added limitingDataAccessPolicyId to shared account mutations
  • Added 579 lines of types:
    • User management (groups, authentication domains, users with filtering/pagination)
    • Authorization management (roles, grants, search containers)
    • Account management (managed accounts)
    • NRDB query types (metadata, results, progress)
    • Actor type for organization-scoped queries

Customer Administration Package

Fixed input filter field types for proper GraphQL schema compliance:

  • Changed non-nullable fields to required (In arrays, Eq strings)
  • Changed filter structs to pointers where optional (DataAccessPolicyId, Grantee, ScopeV2Type, etc.)

Tutone Configuration

  • Added organization query configuration under actor path
  • Added field type overrides for new filter types to ensure pointer generation

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@11a6568). Learn more about missing BASE report.
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
pkg/organization/organization_api.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1347   +/-   ##
=======================================
  Coverage        ?   36.51%           
=======================================
  Files           ?      135           
  Lines           ?     6170           
  Branches        ?        0           
=======================================
  Hits            ?     2253           
  Misses          ?     3717           
  Partials        ?      200           
Flag Coverage Δ
integration 2.98% <0.00%> (?)
unit 36.33% <20.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pranav-new-relic
Copy link
Member Author

@copilot based on all of the files changed in this PR as you may find, can you please generate a comprehensive, yet concise description for this PR that I can add to the description field here? You may want to do so by generating a temporary README.md file in the patch that you would open, from which I shall copy the contents and attach to the description of the PR here. Please ensure that we cover key details - the description does not need to be too elaborate, but should be able to briefly explain the changes made here, the packages affected and a gist of things which have moved across such as datatypes, the API files and more.

Copy link

Copilot AI commented Nov 18, 2025

@pranav-new-relic I've opened a new pull request, #1348, to work on those changes. Once the pull request is ready, I'll request review from you.

@pranav-new-relic pranav-new-relic force-pushed the customeradministration-organization-pkgs-upgrades branch from 852111f to bb73117 Compare November 21, 2025 12:41
@pranav-new-relic pranav-new-relic marked this pull request as ready for review November 21, 2025 13:14
@pranav-new-relic pranav-new-relic merged commit 1836e9a into main Nov 21, 2025
14 checks passed
@pranav-new-relic pranav-new-relic deleted the customeradministration-organization-pkgs-upgrades branch November 21, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments