feat(region): add Japan (JP) region support#1391
Conversation
Add JP region with NerdGraph endpoint for Japan datacenter deployment. Changes: - Add JP constant to region names - Add JP entry in Regions map with nerdGraphBaseURL - Add 'jp' case in Parse function - Add corresponding unit tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
+ Coverage 30.74% 30.76% +0.02%
==========================================
Files 142 142
Lines 6753 6755 +2
==========================================
+ Hits 2076 2078 +2
Misses 4477 4477
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| pairs := map[Name]string{ | ||
| US: "https://api.newrelic.com/graphql", | ||
| EU: "https://api.eu.newrelic.com/graphql", | ||
| JP: "https://one.jp.newrelic.com/graphql", |
There was a problem hiding this comment.
@akifullahkhan-png - based on the existing convention with EU, should this not be https://api.jp.newrelic.com/graphql instead of https://one.jp.newrelic.com/graphql? Given this is a platform change, I'll try finding this out myself - but if we have this mentioned somewhere in the docs/the initiatives shared with us, can you please point me to such a reference? Thanks!
There was a problem hiding this comment.
@pranav-new-relic I got this endpoint from help-tdp, here is the related thread- https://newrelic.slack.com/archives/C01508Q2879/p1775580274371149?thread_ts=1775542419.946949&cid=C01508Q2879
| }, | ||
| JP: { | ||
| name: "JP", | ||
| nerdGraphBaseURL: "https://one.jp.newrelic.com/graphql", |
There was a problem hiding this comment.
There was a problem hiding this comment.
Responded in above comment.
Change JP nerdGraphBaseURL from browser UI endpoint to API endpoint: - From: https://one.jp.newrelic.com/graphql (browser UI) - To: https://api.jp.newrelic.com/graphql (API endpoint) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add support for the new Japan (JP) datacenter region: Code changes: - Add "JP" to provider region validation - Add "jp01" to account management region codes - Add "JP" to alert channel resource and data source validation - Add JP integration tests following EU pattern - Add JP CloudWatch metrics URL to AWS cloud integration example Documentation updates: - Update provider configuration guide - Update migration guide v2 - Update cloud integrations guide - Update AWS auto discovery guide - Update account management resource docs - Update alert channel resource docs - Update main provider docs Depends on: newrelic/newrelic-client-go#1391 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4 participants
Summary
https://one.jp.newrelic.com/graphql)Context
This change supports deploying New Relic services in the new Japan (jp-production) datacenter, enabling customers to link their AWS and GCP accounts to New Relic via Terraform in the JP region.
Test plan
go test -tags unit ./pkg/region/...)🤖 Generated with Claude Code