feat: allow split-namespace gathering for AgentControl#243
Conversation
DavSanchez
left a comment
There was a problem hiding this comment.
LGTM!
Has this been tested? I ask because I'm not sure what would be the output of the getResources function and if it makes sense at the "other end" of the streaming.
For example, would it be the same if inside getResources the result was [][]byte and inside Execute we call tasks.StreamBlob(string(r)), stream) for each []byte element in the slice?
Yes, I tested it and works as expected, I thought about parallelizing it more, but it's done sequntially so the resources don't get mixed. |
## Task Updates * A new command line option `-ac-agents-namespace` was added for specifying a namespace for Agent Control agents ([#243](#243)). The following tasks have been updated to use the new namespace: * K8s/Resources/Config * K8s/Resources/Daemonset * K8s/Resources/Deploy * K8s/Resources/Pods ## Fixes * GLIBC related errors such as `/lib64/libc.so.6: version 'GLIBC_2.34' not found` have been resolved ([#244](#244)).
On newest versions of AC 2 namespaces are used the main one and one for the agents.
This task allows adding a flag specifying an the extra namespace where the agent control agents reside.
The Resources will be scrapped from both namespaces,