Skip to content

feat: allow split-namespace gathering for AgentControl#243

Merged
daffinito merged 1 commit into
newrelic:mainfrom
alvarocabanas:main
Jul 9, 2025
Merged

feat: allow split-namespace gathering for AgentControl#243
daffinito merged 1 commit into
newrelic:mainfrom
alvarocabanas:main

Conversation

@alvarocabanas

Copy link
Copy Markdown
Contributor

On newest versions of AC 2 namespaces are used the main one and one for the agents.
This task allows adding a flag specifying an the extra namespace where the agent control agents reside.
The Resources will be scrapped from both namespaces,

@DavSanchez DavSanchez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Has this been tested? I ask because I'm not sure what would be the output of the getResources function and if it makes sense at the "other end" of the streaming.

For example, would it be the same if inside getResources the result was [][]byte and inside Execute we call tasks.StreamBlob(string(r)), stream) for each []byte element in the slice?

@alvarocabanas

Copy link
Copy Markdown
Contributor Author

LGTM!

Has this been tested? I ask because I'm not sure what would be the output of the getResources function and if it makes sense at the "other end" of the streaming.

For example, would it be the same if inside getResources the result was [][]byte and inside Execute we call tasks.StreamBlob(string(r)), stream) for each []byte element in the slice?

Yes, I tested it and works as expected, I thought about parallelizing it more, but it's done sequntially so the resources don't get mixed.

@daffinito daffinito merged commit 2f230cb into newrelic:main Jul 9, 2025
13 of 15 checks passed
daffinito added a commit that referenced this pull request Jul 10, 2025
## Task Updates

* A new command line option `-ac-agents-namespace` was added for specifying a namespace for Agent Control agents ([#243](#243)). The following tasks have been updated to use the new namespace:
  * K8s/Resources/Config
  * K8s/Resources/Daemonset
  * K8s/Resources/Deploy
  * K8s/Resources/Pods

## Fixes

* GLIBC related errors such as `/lib64/libc.so.6: version 'GLIBC_2.34' not found` have been resolved ([#244](#244)).
@daffinito daffinito mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants