Skip to content

fix: Update compatible version check for Jboss EAP #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffinito merged 3 commits into from
Aug 6, 2025
Merged

fix: Update compatible version check for Jboss EAP #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb72204
fix: Update compatible version check for Jboss EAP
nr-linbaker Aug 6, 2025
37d1648
chore: Update jbosseap_test.go with new accepted versions
nr-linbaker Aug 6, 2025
c2484c6
chore: Update jbosseap_test.go version check
nr-linbaker Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/java/appserver/jbosseap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ func (p JavaAppserverJbossEapCheck) getJbossFileLinux() (string, error) {
}

func versionCheckJboss(version string) (status tasks.Status, summary string) {
compatibilityRequirements := []string{"6-6.*"}
compatibilityRequirements := []string{"6+"}
versionSplit := strings.Split(version, ".")
var err error
isCompatible := false
Expand Down
4 changes: 2 additions & 2 deletions tasks/java/appserver/jbosseap_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ func TestVersionCheckJboss(t *testing.T) {
version string
want tasks.Status
}{
{version: "7.0", want: tasks.Failure},
{version: "8.0", want: tasks.Success},
{version: "6.2", want: tasks.Success},
{version: "5.2", want: tasks.Failure},
{version: "2.11", want: tasks.Failure},
{version: "not valid version", want: tasks.Error},
{version: "7.11.2.GA", want: tasks.Failure},
{version: "5.11.2.GA", want: tasks.Failure},
{version: "6.1.2.GA", want: tasks.Success},
}

Expand Down
Loading