chore: Refactor usages of File. and Directory. to use wrappers#3058
Merged
tippmar-nr merged 1 commit intomainfrom Mar 27, 2025
Merged
chore: Refactor usages of File. and Directory. to use wrappers#3058tippmar-nr merged 1 commit intomainfrom
File. and Directory. to use wrappers#3058tippmar-nr merged 1 commit intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3058 +/- ##
==========================================
+ Coverage 82.18% 82.22% +0.04%
==========================================
Files 477 477
Lines 30623 30625 +2
Branches 3426 3426
==========================================
+ Hits 25166 25180 +14
+ Misses 4658 4644 -14
- Partials 799 801 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
Is there value in making these changes if we do not add unit tests to the code, or do not plan to add unit tests to the code? If we do plan on adding unit tests, and this is just the first step in that process, then I think it is fine. Otherwise, I do not think we should make these changes. |
jaffinito
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File.andDirectory.to useIFileWrapperandIDirectoryWrapperinstead.IFileWrapperandIDirectoryWrapperas needed with default pass-through implementation.Instanceproperty toFileWrapperandDirectoryWrapperfor use in static methodsIFileReaderWrapperand moves implementation toIFileWrapperandFileWrapperPath.as that usage is ubiquitous throughout the codebase and we haven't previously had a need to mock that functionality for tests.