Skip to content

fix: Specify a non-infinite timeout when creating HttpClient and SocketsHttpHandler instances.#3084

Merged
tippmar-nr merged 6 commits intomainfrom
fix/http-client-timeout
Apr 4, 2025
Merged

fix: Specify a non-infinite timeout when creating HttpClient and SocketsHttpHandler instances.#3084
tippmar-nr merged 6 commits intomainfrom
fix/http-client-timeout

Conversation

@tippmar-nr
Copy link
Copy Markdown
Member

@tippmar-nr tippmar-nr commented Apr 3, 2025

Use the configured collector timeout value instead of a hard-coded Timespan.Infinite when creating HttpClient and SocketsHttpHandler instances.

Fixes #3083

@tippmar-nr tippmar-nr requested a review from a team as a code owner April 3, 2025 19:01
@tippmar-nr tippmar-nr enabled auto-merge (squash) April 4, 2025 13:51
@tippmar-nr tippmar-nr merged commit 6f72158 into main Apr 4, 2025
97 checks passed
@tippmar-nr tippmar-nr deleted the fix/http-client-timeout branch April 4, 2025 13:56
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.27%. Comparing base (12e1743) to head (73ae9b9).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...ic/Agent/Core/DataTransport/Client/NRHttpClient.cs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   82.28%   82.27%   -0.02%     
==========================================
  Files         477      477              
  Lines       30659    30636      -23     
  Branches     3429     3424       -5     
==========================================
- Hits        25228    25206      -22     
+ Misses       4630     4627       -3     
- Partials      801      803       +2     
Flag Coverage Δ
Agent 83.33% <80.00%> (-0.02%) ⬇️
Profiler 72.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ic/Agent/Core/DataTransport/Client/NRHttpClient.cs 86.27% <80.00%> (+7.89%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent appears to deadlock when sending data to New Relic

3 participants