fix: Null reference exception in Asp.NET Core 6+ browser monitoring injection. #3102
Merged
tippmar-nr merged 3 commits intomainfrom Apr 17, 2025
Merged
fix: Null reference exception in Asp.NET Core 6+ browser monitoring injection. #3102tippmar-nr merged 3 commits intomainfrom
tippmar-nr merged 3 commits intomainfrom
Conversation
nrcventura
approved these changes
Apr 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3102 +/- ##
==========================================
- Coverage 82.33% 82.28% -0.06%
==========================================
Files 477 477
Lines 30636 30636
Branches 3424 3424
==========================================
- Hits 25225 25208 -17
- Misses 4609 4626 +17
Partials 802 802
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, neither of the instrumentation wrappers for Asp.NET Core 6+ will be hit (for example, when OpenAPI and Swagger is configured), which means that no transaction will be created and can result in a null reference exception.
Also updates the pipeline that executes the browser injection wrapper to check for a valid transaction, which will keep the wrapper from running when there is no transaction.
Fixes #3101