ci: Add agent configurability and convenient local testing to performance tests#3498
Merged
nr-ahemsath merged 27 commits intomainfrom Mar 23, 2026
Merged
ci: Add agent configurability and convenient local testing to performance tests#3498nr-ahemsath merged 27 commits intomainfrom
nr-ahemsath merged 27 commits intomainfrom
Conversation
1. Change the agent health check to just look for "agent fully connected" so we don't have to have the agent log level set to DEBUG 2. Don't dump traffic driver and test app logs by default 3. Parameterize the python executable used to clean up the test output (part of follow-on work to make running comparisons locally convenient)
…ic/newrelic-dotnet-agent into ci/performance-test-visualization
…uccessful overnight build
Add the ability to configure the agent (and the test app, for that matter) via env vars. Also remove the standalone "performance_tests.yml" workflow since it is redundant - its logic is now in actions/run-perf-test/action.yml, and if you want to run a single performance test case in ci, you can use compare_performance.yml with just a single run specified.
Also stop creating unique application names for each test run that pollute our sandbox
Also, remove log level setting from docker compose as it wasn't being set that way; specify it as one of the extra env var args if desired.
1. Add a VS solution file 2. Add a pylint (python linter) config file 3. Implement linter suggestions 4. Some hand refactoring of run-perf-test.py 5. Make the agent log checks more correct and meaningful
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3498 +/- ##
=======================================
Coverage 81.79% 81.79%
=======================================
Files 508 508
Lines 34220 34220
Branches 4040 4040
=======================================
Hits 27990 27990
Misses 5265 5265
Partials 965 965
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
nrcventura
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains several improvements to the performance testing solution:
run-performance-tests.py) for easily running performance tests locally. Python was chosen because I wanted to use a YAML config file for the tests, andbashhas no native YAML parsing capability.git-bashvs. WSL2bash, AND how those paths interact with Docker volume mounting on Windows.Here is the latest successful performance comparison run from this branch: https://github.com/newrelic/newrelic-dotnet-agent/actions/runs/23362875633