test: fix flaky CSP and Lambda integration tests#3505
Merged
tippmar-nr merged 2 commits intomainfrom Mar 25, 2026
Merged
Conversation
- CSP tests: Replace GetTransactionSamples().FirstOrDefault() with TryGetTransactionSample(transactionName) to target the GetWithData transaction. Previously, if the ThrowException trace was harvested first, the test failed asserting response.status 200 vs actual 500. - Lambda tests: Add initial 5s delay and increase warmup retry count from 3 to 5 in LambdaTestToolFixture.WarmUpTestTool(), giving the mock Lambda test tool more time to start on loaded CI runners. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3505 +/- ##
==========================================
- Coverage 81.79% 81.77% -0.02%
==========================================
Files 508 508
Lines 34220 34220
Branches 4040 4040
==========================================
- Hits 27990 27984 -6
- Misses 5265 5269 +4
- Partials 965 967 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jaffinito
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetTransactionSamples().FirstOrDefault()which non-deterministically picked theThrowExceptiontrace (500) instead of theGetWithDatatrace (200), causing spurious assertion failures. Fixed by usingTryGetTransactionSample(transactionName)to target the correct transaction.WarmUpTestTool()could exhaust its 3 retries before the mock Lambda test tool started listening, especially on cold start in CI. Added 5s initial delay and increased retries from 3 to 5.Test plan
AwsLambda.Customintegration test suiteCSPintegration test suite🤖 Generated with Claude Code