test: Refactor docker-compose files in container tests#3524
Merged
nr-ahemsath merged 3 commits intomainfrom Apr 6, 2026
Merged
test: Refactor docker-compose files in container tests#3524nr-ahemsath merged 3 commits intomainfrom
nr-ahemsath merged 3 commits intomainfrom
Conversation
tippmar-nr
reviewed
Apr 6, 2026
tippmar-nr
approved these changes
Apr 6, 2026
Member
tippmar-nr
left a comment
tippmar-nr
left a comment
There was a problem hiding this comment.
Nice work. Should make things easier in the future!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3524 +/- ##
==========================================
- Coverage 81.79% 81.77% -0.02%
==========================================
Files 508 508
Lines 34228 34228
Branches 4040 4040
==========================================
- Hits 27996 27990 -6
- Misses 5266 5270 +4
- Partials 966 968 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
Merging without waiting for the LLM tests to pass - this is a known current failure due and unrelated to these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces code duplication in the container integration tests by factoring common logic out of the many docker-compose files into a base file which the rest extend from.
This also combines the two Dockerfiles used for building the images for amazonlinux and fedora (which were identical except for which base image they started from) by passing the relevant base image as an argument to
Dockerfile.CustomBaseImage; the instructions for doing so have been updated in the README.md in CustomBaseContainerBuild.