Conversation
|
|
purple4reina
force-pushed
the
opencensus-traces
branch
from
a69789d to
db53da8
Compare
|
Okay, I updated this Pull Request to represent what our team implemented for the OpenCensus go exporter! 🎉 |
|
@rachelleahklein and @jkwatson This is reready for your review 🎈 |
opencensus/OpenCensus-Traces.md
Outdated
There was a problem hiding this comment.
do we have access to an status message? If so, we should also populate error.message here.
There was a problem hiding this comment.
Oh great idea! We didn't do this in our version of the Go OpenCensus exporter but it's a great idea. I'll add it!
Since the Status isn't always an error (say the code is 0) then maybe we shouldn't use the word "error". How about three attributes (all under the attributes map) error (bool), status.code (int), and status.message (string)?
| |`parent.id`|`Span.ParentSpanID`|string|yes (except root span)|The span id of the previous caller of this span. Can be empty if this is the first span in which case the key should be omitted.| | ||
| |`timestamp`|`Span.StartTime`|long|yes|Epoch ms timestamp| | ||
| |`duration.ms`|`Span.EndTime` - `Span.StartTime`|float|yes|Duration of this span in milliseconds| | ||
| |`service.name`|(none)|string|yes| The name of the service that created this span. This value is not gathered from OpenCensus. Instead it should be set directly by the user when defining the Exporter.| |
There was a problem hiding this comment.
name, parent.id, duration.ms and service.name are all in the attributes rather than the top level. Should that be called out in here?
4 participants
A spec for writing Trace (aka span) Exporters.
Open TODOs: