Clarify conflict handling for attributes#41
Open
nrcventura wants to merge 1 commit intonewrelic:masterfrom
Open
Clarify conflict handling for attributes#41nrcventura wants to merge 1 commit intonewrelic:masterfrom
nrcventura wants to merge 1 commit intonewrelic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of this change is clarify how conflicts between OTel span attributes and New Relic span attributes should be handled.
The current proposal is that the special New Relic attributes should take precedence over any attributes defined in the OTel span attributes. The special New Relic attributes typically drive some sort of business or UI logic, and an "arbitrary" value for an attribute of the same name defined in the OTel attributes could lead to a problem.