DOUBLE REPORT LINES COMMENTED

newrelic · Jan 24, 2024 · 719a7ae · 719a7ae
1 parent 0d876ec
commit 719a7ae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/Agent/CrashHandler/NRMAExceptionHandlerManager.m b/Agent/CrashHandler/NRMAExceptionHandlerManager.m
@@ -107,6 +107,7 @@ - (instancetype) initWithLastSessionsAttributes:(NSDictionary*)attributes
             [_reportManager processReportsWithSessionAttributes:attributes
                                                 analyticsEvents:events];
 
+            // DOUBLE REPORT POSSIBLE: [NRMAExceptionHandler calls uploadCrashReports when _crashReporter hasPendingCrashreport] is true on app launch.
             [self.uploader uploadCrashReports];
         }
 

diff --git a/Agent/General/NewRelicAgentInternal.m b/Agent/General/NewRelicAgentInternal.m
@@ -494,6 +494,7 @@ - (void) onSessionStart {
     // Attempt to upload crash report files (if any exist)
     if ([NRMAFlags shouldEnableCrashReporting]) {
 
+        // DOUBLE REPORT POSSIBLE: Upload crash reports is called when "onSessionStart" fires due to [NewRelicAgentInternal applicationWillEnterForeground];
         [[NRMAExceptionHandlerManager manager].uploader uploadCrashReports];
     }