[iOS] NR-178557 Adds visionOS support to iOS agent #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will add visionOS target tests |
smalsam-newr
previously approved these changes
Nov 6, 2023
| @@ -497,8 +497,10 @@ - (void) onSessionStart { | |||
|
|
|||
| // Attempt to upload crash report files (if any exist) | |||
| if ([NRMAFlags shouldEnableCrashReporting]) { | |||
| #if !TARGET_OS_VISION | |||
|
|
|||
| [[NRMAExceptionHandlerManager manager].uploader uploadCrashReports]; | |||
There was a problem hiding this comment.
I'm guessing VisionOS doesn't give us crash reports, similar to WatchOS?
There was a problem hiding this comment.
Im still investigating this but I believe, like watchOS, PLCrashReporter doesn't yet support this. So we'd have to do something similar to Firebase's watchOS crash support for these I believe. I will make an additional ticket for investigating crash reporting possibilities with AVP (or at least the simulator until I get a real device).
cdillard-NewRelic
changed the title
… visionOS # Conflicts: # Test Harness/NRTestApp/NRTestApp.xcodeproj/project.pbxproj
… visionOS # Conflicts: # Agent/General/NewRelicAgentInternal.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://new-relic.atlassian.net/browse/NR-178557