Offline storage to file system on failed upload #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cdillard-NewRelic
previously approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Latest update looking good to me I see the log when a failed harvest is persisted to disk
NewRelic(DEV,0x2804c1640): NRMAOfflineStorage.m:47 -[NRMAOfflineStorage persistDataToDisk:]
Successfully persisted failed upload data to disk for offline storage.
and when a harvest is successful I see the proper logs referencing offline harvests sent now that internet is back.
NewRelic(DEV,0x2804eecc0): NRMAOfflineStorage.m:66 -[NRMAOfflineStorage getAllOfflineData:]_block_invoke
Offline storage to be uploaded from 2023-12-28-10-58-57.txt
NewRelic(DEV,0x2804eecc0): NRMAHarvesterConnection.m:39 -[NRMAHarvesterConnection sendOfflineStorage]
Number of offline data posts: 1
I tested both airplane mode and 100% loss mode (via Network Link Conditioner.
Id say this is ready to be feature flagged behind a "OfflineInstrumentation" or similarly named flag and shipped 👍
ywang-nr
reviewed
Jan 2, 2024
ywang-nr
reviewed
Jan 2, 2024
smalsam-newr
reviewed
Jan 9, 2024
mbruin-NR
commented
Jan 11, 2024
mbruin-NR
commented
Jan 11, 2024
mbruin-NR
commented
Jan 11, 2024
cdillard-NewRelic
previously approved these changes
Jan 11, 2024
Co-authored-by: Chris Dillard <[email protected]>
…r offline in handled exceptions and crashes
smalsam-newr
previously approved these changes
Jan 26, 2024
cdillard-NewRelic
previously approved these changes
Jan 29, 2024
…e missed or duplicated reports
mbruin-NR
dismissed stale reviews from cdillard-NewRelic and smalsam-newr
via
a87bd97
cdillard-NewRelic
previously approved these changes
Jan 31, 2024
smalsam-newr
approved these changes
Feb 13, 2024
|
Please request code review when PR is ready with additional changes. |
cdillard-NewRelic
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft for the offline storage has the harvest data that failed to send stored to the local file system when a request has a -1009 or -1001. All of the recorded harvests are then sent immediately after a request succeeds an upload.
Consider also adding -1003, -1004, and -1005.