Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NR-214196] Fix NRMAHarvester defaults #195

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

cdillard-NewRelic
Copy link
Member

@cdillard-NewRelic cdillard-NewRelic commented Jan 10, 2024

https://new-relic.atlassian.net/browse/NR-214196

Adds handling for the case that harvester /connect is determined as success even tho the dictionary is missing harvester configuration elements.

@cdillard-NewRelic cdillard-NewRelic changed the title [WIP] Fix NRMAHarvester defaults [WIP] [https://new-relic.atlassian.net/browse/NR-214196] Fix NRMAHarvester defaults Jan 11, 2024
@cdillard-NewRelic cdillard-NewRelic changed the title [WIP] [https://new-relic.atlassian.net/browse/NR-214196] Fix NRMAHarvester defaults [WIP] [NR-214196] Fix NRMAHarvester defaults Jan 11, 2024
@cdillard-NewRelic cdillard-NewRelic marked this pull request as ready for review January 11, 2024 20:08
@cdillard-NewRelic cdillard-NewRelic changed the title [WIP] [NR-214196] Fix NRMAHarvester defaults [NR-214196] Fix NRMAHarvester defaults Jan 11, 2024
mbruin-NR
mbruin-NR previously approved these changes Jan 19, 2024
smalsam-newr
smalsam-newr previously approved these changes Jan 23, 2024
@cdillard-NewRelic cdillard-NewRelic merged commit a956be8 into develop Jan 29, 2024
5 checks passed
@cdillard-NewRelic cdillard-NewRelic deleted the fix/NR-214196 branch January 29, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants