[NR-218350] [iOS] Duplicate crash uploaded on App launch #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdillard-NewRelic
changed the title
|
Wonder if it makes sense to expose this "fix" as a feature flag? something like |
|
@smalsam-newr RE: Check in the old repository for how long this bug has existed of duplicate crash reporting. NRMAExceptionHandlerManager where we call uploadCrashReports and It looks like both locations have included the call to uploadCrashReports for at least 4 years |
|
We will fix this another way by adding intelligence to NRMACrashDataUploader so that it never uploads duplicate crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to uploadCrashReports when initializing NRMAExceptionHandlerManager