Nr 318119 auto collect stdout & stderr logs #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdillard-NewRelic
requested review from
cdillard-NewRelic
and removed request for
cdillard-NewRelic
… look further into it
…orrectly." This reverts commit 28790a5.
…ct if remote logging is enabled
…ose them if needed
Co-authored-by: Chris Dillard <[email protected]>
|
Do we think there is anyway to allow the console and auto collected logs to work at the same time? If not its fine but we should note it in the docs. Thanks! |
I can't think of a way to put it on the console too, maybe we could try to redirect back to console on every log message but that's not how it's setup. It's going to be part of the docs. |
smalsam-newr
approved these changes
Nov 22, 2024
cdillard-NewRelic
approved these changes
Nov 22, 2024
| @@ -47,7 +47,8 @@ + (NRMAFeatureFlags) featureFlags | |||
| NRFeatureFlag_NetworkRequestEvents | | |||
| NRFeatureFlag_RequestErrorEvents | | |||
| NRFeatureFlag_DistributedTracing | | |||
| NRFeatureFlag_AppStartMetrics; | |||
| NRFeatureFlag_AppStartMetrics | | |||
| NRFeatureFlag_AutoCollectLogs; | |||
There was a problem hiding this comment.
NRFeatureFlag_AutoCollectLogs must be disabled by default. As my resolved comment indicated. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://new-relic.atlassian.net/browse/NR-318119