Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass nativePlatform as instrumentation insights name, collector.name … #321

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

cdillard-NewRelic
Copy link
Member

…is hybrid paltform.

@cdillard-NewRelic cdillard-NewRelic merged commit 60a7e15 into develop Oct 23, 2024
7 checks passed
@ndesai-newrelic
Copy link

@cdillard-NewRelic the change is only required for collector name.

@cdillard-NewRelic
Copy link
Member Author

It was stated that "instrumentation.name" should be either iOSAgent, watchOSAgent, or tvOSAgent regardless of hybrid or not.
It was stated that "collector.name" should be either iOSAgent, watchOSAgent, or tvOSAgent if not hybrid or
IF it is hybrid it should be one of:
#define kNRMAPlatformString_Cordova @"Cordova"
#define kNRMAPlatformString_PhoneGap @"PhoneGap"
#define kNRMAPlatformString_Xamarin @"Xamarin"
#define kNRMAPlatformString_Unity @"Unity"
#define kNRMAPlatformString_Appcelerator @"Appcelerator"
#define kNRMAPlatformString_ReactNative @"ReactNative"
#define kNRMAPlatformString_Flutter @"Flutter"
#define kNRMAPlatformString_Capacitor @"Capacitor"
#define kNRMAPlatformString_MAUI @"MAUI"
#define kNRMAPlatformString_Unreal @"Unreal"

Does this not sound right please?

Please clearly describe with a JSON example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants