Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-352010 Changed NRMASAM to add the persisted attributes individually so that they get re-persisted #342

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

mbruin-NR
Copy link
Contributor

Changed NRMASAM to add the persisted attributes individually so that they get re-persisted which is closer to how the old event system does it in SessionAttributeManager::restorePersistentAttributes().
Now the session attributes should persist until removed like in the old event system.

smalsam-newr
smalsam-newr previously approved these changes Jan 29, 2025
Copy link
Member

@cdillard-NewRelic cdillard-NewRelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanted to run your code locally and see what happens on bg, looks good 👍

Copy link
Member

@cdillard-NewRelic cdillard-NewRelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good testing.

@mbruin-NR mbruin-NR merged commit 521b615 into develop Jan 31, 2025
11 checks passed
@mbruin-NR mbruin-NR deleted the NR-352010 branch January 31, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants