Resolve deadlock between harvest thread and JVM shutdown thread#2539
Open
Resolve deadlock between harvest thread and JVM shutdown thread#2539
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2539 +/- ##
============================================
- Coverage 70.32% 70.30% -0.02%
- Complexity 10059 10117 +58
============================================
Files 847 855 +8
Lines 40913 41109 +196
Branches 6201 6232 +31
============================================
+ Hits 28771 28901 +130
- Misses 9343 9385 +42
- Partials 2799 2823 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbedell-newrelic
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2514
Replaces the synchronized methods and code blocks with a
ReentrantLockinstance. In theharvestNow()method, thetryLock()method is called with a 200ms timeout, so even if two threads are fighting for the lock, they will never be deadlocked since thetryLockwill timeout and continue.Wrote a few unit tests to (hopefully) reproduce the scenario and verify no deadlocks occur.