Add Kotlin coroutines instrumentation tests#2705
Open
sharvath-newrelic wants to merge 7 commits intomainfrom
Open
Add Kotlin coroutines instrumentation tests#2705sharvath-newrelic wants to merge 7 commits intomainfrom
sharvath-newrelic wants to merge 7 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2705 +/- ##
============================================
- Coverage 70.34% 70.31% -0.03%
+ Complexity 10123 10119 -4
============================================
Files 853 853
Lines 41118 41120 +2
Branches 6240 6241 +1
============================================
- Hits 28923 28915 -8
- Misses 9372 9375 +3
- Partials 2823 2830 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@dhilpipre This PR does some work to strengthen the Kotlin coroutines test suite. I was curious if you might have any commentary/recommendations for additions or revisions that could be made per this PR? |
Collaborator
|
@sharvath-newrelic I'll take a look and let you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Per this PR, classloading issues resulting from the porting of Kotlin lab code have been resolved. Additionally, unit tests for the Kotlin coroutines instrumentation modules (1.4, 1.7 and 1.9) have been added with assertions to verify NR agent behavior. Tests help to verify:
It's worth noting
async.ktandPauseService.ktwere not ported for the following reasons:async.kt:- Contained example code demonstrating async/await patterns but without assertions
- All patterns have been incorporated into
CoroutinesTest.ktwith Introspector-based verification- The new tests cover the same scenarios (async, awaitAll, multiple deferreds) with agent behavior validation
PauseService.kt:- No longer needed as new tests use
delay()directly within test methodsRelated Github Issue
Resolves #2675
Resolves #2661
Testing
To run the instrumentation tests manually, run the following command template via the terminal:
./gradlew instrumentation:kotlin-coroutines-1.x:test --parallel