Expire Tokens when a Reactive Subscription is cancelled#2798
Open
jbedell-newrelic wants to merge 1 commit intomainfrom
Open
Expire Tokens when a Reactive Subscription is cancelled#2798jbedell-newrelic wants to merge 1 commit intomainfrom
jbedell-newrelic wants to merge 1 commit intomainfrom
Conversation
…eout if a subscription is cancelled, but never disposed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2798 +/- ##
============================================
- Coverage 70.40% 70.39% -0.02%
+ Complexity 10386 10384 -2
============================================
Files 869 869
Lines 42017 42017
Branches 6386 6386
============================================
- Hits 29584 29577 -7
- Misses 9550 9554 +4
- Partials 2883 2886 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Subscription is created but neither onComplete nor onError get called the Token created will never expire normally, and will end up timing out. This is known to be possible when a subscription is cancelled. This update expires the token in this case.
Fixes: #2515