Skip to content

Expire Tokens when a Reactive Subscription is cancelled#2798

Open
jbedell-newrelic wants to merge 1 commit intomainfrom
ReactorUpdates
Open

Expire Tokens when a Reactive Subscription is cancelled#2798
jbedell-newrelic wants to merge 1 commit intomainfrom
ReactorUpdates

Conversation

@jbedell-newrelic
Copy link
Contributor

@jbedell-newrelic jbedell-newrelic commented Mar 16, 2026

When a Subscription is created but neither onComplete nor onError get called the Token created will never expire normally, and will end up timing out. This is known to be possible when a subscription is cancelled. This update expires the token in this case.

Fixes: #2515

…eout if a subscription is cancelled, but never disposed.
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.39%. Comparing base (2170c1e) to head (016860d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2798      +/-   ##
============================================
- Coverage     70.40%   70.39%   -0.02%     
+ Complexity    10386    10384       -2     
============================================
  Files           869      869              
  Lines         42017    42017              
  Branches       6386     6386              
============================================
- Hits          29584    29577       -7     
- Misses         9550     9554       +4     
- Partials       2883     2886       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[Spike] Investigate netty-reactor module for optimization/fixes

2 participants