Do not merge - PR test run for fork PR - Migrate shadow plugin to gradleup#2950
Draft
jtduffy wants to merge 9 commits into
Draft
Do not merge - PR test run for fork PR - Migrate shadow plugin to gradleup#2950jtduffy wants to merge 9 commits into
jtduffy wants to merge 9 commits into
Conversation
…issue #2862) - Replace plugin id and dependency coord with com.gradleup.shadow:shadow-gradle-plugin:8.3.0 in buildSrc/build.gradle, instrumentation-build, and newrelic-opentelemetry-agent-extension - Add explicit org.apache.ant:ant:1.10.14 dependency to buildSrc; shadow 8.3.0 no longer bundles/shades Ant internally so ZipEntry/ZipOutputStream are not available transitively - Fix zip imports in DependencyPatcher and Log4j2PluginFileMover from shaded shadow.org.apache.tools.zip.* to unshaded org.apache.tools.zip.* - Add getName() override to both Transformer implementations; shadow 8.3.0 Transformer interface now extends org.gradle.api.Named requiring this method - Upgrade Gradle wrapper 7.5.1 -> 8.3; com.gradleup.shadow requires Gradle 8.3 minimum - Fix Gradle 8 API removals required by the wrapper upgrade: - cache_weave_attributes.gradle.kts: JavaExec.main -> mainClass - infinite-tracing/build.gradle.kts: jacoco.reportsDir removed, xml.isEnabled -> required, html.destination -> html.outputLocation - newrelic-weaver/build.gradle: replace undefined jdk8 property reference with javaToolchains.compilerFor API to resolve JDK 8 path dynamically Pinned shadow at exactly 8.3.0 (not later) because 8.3.4+ broke Java 8 support per upstream reports. Verified Transformer/TransformerContext interfaces unchanged at 8.3.0 so no interface-name migration needed.
…teVersionProperties Gradle 8 strict validation catches implicit task dependencies that Gradle 7 allowed silently. compileJava11Java reads Agent.properties produced by generateVersionProperties without declaring it as a dependency, causing failures in parallel builds (./gradlew clean jar --parallel).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
============================================
+ Coverage 70.76% 70.78% +0.01%
- Complexity 10659 10660 +1
============================================
Files 879 877 -2
Lines 42971 42962 -9
Branches 6501 6501
============================================
Hits 30409 30409
+ Misses 9627 9618 -9
Partials 2935 2935 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.