New Patcher instance to remove problem enum values from the shadowed jspecify NullMarked class#2982
Open
jtduffy wants to merge 3 commits into
Open
New Patcher instance to remove problem enum values from the shadowed jspecify NullMarked class#2982jtduffy wants to merge 3 commits into
jtduffy wants to merge 3 commits into
Conversation
sharvath-newrelic
approved these changes
Jul 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2982 +/- ##
============================================
+ Coverage 70.83% 70.84% +0.01%
- Complexity 10667 10672 +5
============================================
Files 873 873
Lines 42960 42970 +10
Branches 6501 6503 +2
============================================
+ Hits 30429 30443 +14
- Misses 9596 9598 +2
+ Partials 2935 2929 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
obenkenobi
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2976
Adds a new Patcher instance that runs during the shadowJar task that removes ElementType.MODULE and ElementType.RECORD_COMPONENT from the @target annotation on the shaded jspecify NullMarked class.
Both enum values were introduced after Java 8 and cause ArrayStoreException in Java 8's AnnotationParser
when Spring scans the agent JAR because of the presence of the shaded Caffeine v3 jar.
Also adds a README that summarizes every Patcher instance's functionality.