Remove SpringPointCut#2990
Open
jtduffy wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
============================================
+ Coverage 70.90% 70.95% +0.05%
+ Complexity 10667 10658 -9
============================================
Files 871 870 -1
Lines 42931 42865 -66
Branches 6498 6485 -13
============================================
- Hits 30440 30416 -24
+ Misses 9553 9519 -34
+ Partials 2938 2930 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2867
Removes the SpringPointCut class and replaces it with weave instrumentation classes. This point cut only applied to Spring 3.x - 5.x, so the 6.0.0 spring module wasn't updated.
The point cut instrumented org.springframework.web.servlet.HandlerAdapter#handle. The ported point cut behavior:
@TracetheHandlerAdapter.handle()methodSpringController/{ClassName}, stripping$$EnhancerBysuffix.I'm also sneaking in a minor module rename and verify range change. The previous name/range was incorrect.