Skip to content

Remove SpringPointCut#2990

Open
jtduffy wants to merge 2 commits into
mainfrom
handler-adapter-pointcut-removal
Open

Remove SpringPointCut#2990
jtduffy wants to merge 2 commits into
mainfrom
handler-adapter-pointcut-removal

Conversation

@jtduffy

@jtduffy jtduffy commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Resolves #2867

Removes the SpringPointCut class and replaces it with weave instrumentation classes. This point cut only applied to Spring 3.x - 5.x, so the 6.0.0 spring module wasn't updated.

The point cut instrumented org.springframework.web.servlet.HandlerAdapter#handle. The ported point cut behavior:

  • @Trace the HandlerAdapter.handle() method
  • Sets the segment metric name to SpringController/{ClassName}, stripping $$EnhancerBy suffix.

I'm also sneaking in a minor module rename and verify range change. The previous name/range was incorrect.

@codecov-commenter

codecov-commenter commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.95%. Comparing base (5664ed4) to head (a01eac8).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2990      +/-   ##
============================================
+ Coverage     70.90%   70.95%   +0.05%     
+ Complexity    10667    10658       -9     
============================================
  Files           871      870       -1     
  Lines         42931    42865      -66     
  Branches       6498     6485      -13     
============================================
- Hits          30440    30416      -24     
+ Misses         9553     9519      -34     
+ Partials       2938     2930       -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtduffy jtduffy moved this from Triage to Needs Review in Java Engineering Board Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

Remove unnecessary point cuts

2 participants