Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
=====================================
Coverage 1.11% 1.11%
=====================================
Files 12 12
Lines 30791 30791
=====================================
Hits 342 342
Misses 30444 30444
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1. Include `customAPIKeySecret...` fields in `values.yaml`. 2. Update `deployment.yaml` with new logic to prioritize `customAPIKeySecret...` fields, and if not set, fall back to `personalAPIKey`. 3. Disable `secret.yaml` to eliminate the old secret-creation logic. Aligns with how other charts, like nri-bundle, approach secrets. Improves compatibility with GitOps tools like ArgoCD.
keegoid-nr
force-pushed
the
kmullaney/standard-secrets
branch
from
954ab15 to
59d904d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
enhancement
customAPIKeySecret...fields invalues.yaml.deployment.yamlwith new logic to prioritizecustomAPIKeySecret...fields, and if not set, fall back topersonalAPIKey.secret.yamlto eliminate the old secret-creation logic.Aligns with how other charts (nri-bundle) approach secrets.
Improves compatibility with GitOps tools like ArgoCD.
Type of change
Checklist: