Add support for pre-created Kubernetes secrets in Helm chart#466
Open
dpacheconr wants to merge 1 commit intonewrelic:mainfrom
Open
Add support for pre-created Kubernetes secrets in Helm chart#466dpacheconr wants to merge 1 commit intonewrelic:mainfrom
dpacheconr wants to merge 1 commit intonewrelic:mainfrom
Conversation
Allow users to install the chart with externally managed secrets via customSecretName and customSecretKey values. This enables integration with secret management tools like External Secrets Operator, Sealed Secrets, and Vault. - Add customSecretName and customSecretKey chart values - Make secret creation conditional based on customSecretName - Add helper functions for secret resolution - Update deployment to use configurable secret references - Add documentation and usage examples Also removes deprecated engine: gotpl field from Chart.yaml for Helm v3 compliance. Bump chart version to 1.18.0 (minor version for new feature).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for using pre-created Kubernetes secrets with the Helm chart via new customSecretName and customSecretKey values. This enables integration with external secret management tools like External Secrets Operator, Sealed Secrets, and Vault.
Changes
Backward Compatibility
Fully backward compatible - existing installations continue to work without changes. The default behavior (creating a secret from personalAPIKey) is preserved when customSecretName is not set.
Testing
Documentation
Updated README.md with usage examples for External Secrets Operator, Sealed Secrets, Vault, and manual secret creation.