Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(agent): Removes Monolog library tests #1040

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

mfulb
Copy link
Contributor

@mfulb mfulb commented Mar 24, 2025

The Monolog library tests have been moved to the multiverse tests.
This PR removes the test from the integration tests.
The PR also adds a test for the Monolog detection/state metrics to be consistent with other logging libraries tested in the integration tests.

mfulb added 2 commits March 24, 2025 12:16
The Monolog library tests are now in Multiverse so these
can be removed.
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Mar 24, 2025

Test Suite Status Result
Multiverse 8/8 passing
SOAK 79/79 passing

Missed a couple of files for Monolog
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.22%. Comparing base (c8a539a) to head (25f2b97).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1040      +/-   ##
==========================================
- Coverage   77.87%   77.22%   -0.66%     
==========================================
  Files         198      198              
  Lines       27899    27899              
==========================================
- Hits        21727    21544     -183     
- Misses       6172     6355     +183     
Flag Coverage Δ
agent-for-php-7.2 77.44% <ø> (-0.69%) ⬇️
agent-for-php-7.3 77.46% <ø> (-0.69%) ⬇️
agent-for-php-7.4 77.18% <ø> (-0.69%) ⬇️
agent-for-php-8.0 76.57% <ø> (-0.69%) ⬇️
agent-for-php-8.1 76.97% <ø> (-0.68%) ⬇️
agent-for-php-8.2 76.58% <ø> (-0.68%) ⬇️
agent-for-php-8.3 76.58% <ø> (-0.68%) ⬇️
agent-for-php-8.4 76.60% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants