Skip to content

fix(agent): only try to add exception if it exists#1235

Open
zsistla wants to merge 4 commits into
feat/fibersfrom
fibers/on_null_returnval
Open

fix(agent): only try to add exception if it exists#1235
zsistla wants to merge 4 commits into
feat/fibersfrom
fibers/on_null_returnval

Conversation

@zsistla

@zsistla zsistla commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

If we have a NULL function returnvalue, only try to add an exception if it exists.
Fibers return a null return value on exiting when they are suspended and never resume, but this does not create an exception or error condition in PHP.

@zsistla zsistla requested a review from bduranleau-nr June 12, 2026 22:41
@zsistla zsistla added the fibers label Jun 12, 2026
@newrelic-php-agent-bot

newrelic-php-agent-bot commented Jun 12, 2026

Copy link
Copy Markdown
Test Suite Status Result
Multiverse 16/18 passing
SOAK 139/146 passing

@codecov-commenter

codecov-commenter commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.46%. Comparing base (41ea1dd) to head (53b9a48).

Additional details and impacted files
@@               Coverage Diff               @@
##           feat/fibers    #1235      +/-   ##
===============================================
- Coverage        80.46%   80.46%   -0.01%     
===============================================
  Files              191      191              
  Lines            28308    28309       +1     
===============================================
  Hits             22779    22779              
- Misses            5529     5530       +1     
Flag Coverage Δ
agent-for-php-7.2 80.26% <ø> (ø)
agent-for-php-7.3 80.28% <ø> (ø)
agent-for-php-7.4 80.15% <ø> (ø)
agent-for-php-8.0 79.72% <100.00%> (-0.01%) ⬇️
agent-for-php-8.1 80.04% <100.00%> (-0.01%) ⬇️
agent-for-php-8.2 79.64% <100.00%> (-0.01%) ⬇️
agent-for-php-8.3 ?
agent-for-php-8.4 79.74% <100.00%> (+<0.01%) ⬆️
agent-for-php-8.5 79.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants