Skip to content

fix(agent): fix mongodb instrumentation for PHP 8.0+#878

Merged
bduranleau-nr merged 11 commits into
devfrom
fix/mongodb-before-after
Jun 21, 2024
Merged

fix(agent): fix mongodb instrumentation for PHP 8.0+#878
bduranleau-nr merged 11 commits into
devfrom
fix/mongodb-before-after

Conversation

@bduranleau-nr

@bduranleau-nr bduranleau-nr commented Apr 15, 2024

Copy link
Copy Markdown
Contributor
  • split mongodb instrumentation into before/after inline with OAPI paradigm.
  • remove broken integration tests in favor of Multiverse tests

@newrelic-php-agent-bot

newrelic-php-agent-bot commented Apr 15, 2024

Copy link
Copy Markdown
Test Suite Status Result
Multiverse / passing
SOAK / passing

@codecov-commenter

codecov-commenter commented Apr 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@756c1aa). Learn more about missing BASE report.

Files Patch % Lines
agent/lib_mongodb.c 0.00% 54 Missing ⚠️
agent/php_wrapper.c 0.00% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #878   +/-   ##
======================================
  Coverage       ?   78.57%           
======================================
  Files          ?      193           
  Lines          ?    27290           
  Branches       ?        0           
======================================
  Hits           ?    21443           
  Misses         ?     5847           
  Partials       ?        0           
Flag Coverage Δ
agent-for-php-7.0 77.49% <0.00%> (?)
agent-for-php-7.1 77.24% <0.00%> (?)
agent-for-php-7.2 78.16% <0.00%> (?)
agent-for-php-7.3 78.18% <0.00%> (?)
agent-for-php-7.4 77.89% <0.00%> (?)
agent-for-php-8.0 77.92% <0.00%> (?)
agent-for-php-8.1 77.90% <0.00%> (?)
agent-for-php-8.2 77.50% <0.00%> (?)
agent-for-php-8.3 77.50% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread agent/lib_mongodb.c
@bduranleau-nr bduranleau-nr marked this pull request as ready for review April 16, 2024 15:34
@ZNeumann ZNeumann changed the title fix: update mongodb instrumentation with oapi paradigm fix: update mongodb library instrumentation with oapi paradigm Apr 16, 2024
Comment thread agent/lib_mongodb.c Outdated
Comment thread agent/lib_mongodb.c Outdated
@bduranleau-nr bduranleau-nr force-pushed the fix/mongodb-before-after branch from 19c39de to 64c6306 Compare April 25, 2024 19:51
@lavarou lavarou changed the title fix: update mongodb library instrumentation with oapi paradigm fix(agent): fix mongodb instrumentation for PHP 8.0+ May 8, 2024
Comment thread agent/php_wrapper.c Outdated
Comment thread agent/php_wrapper.c
Comment thread agent/lib_mongodb.c
Comment thread agent/lib_mongodb.c Outdated

@lavarou lavarou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bduranleau-nr bduranleau-nr force-pushed the fix/mongodb-before-after branch from f3164c6 to 6f0d244 Compare June 13, 2024 18:57
@lavarou lavarou added this to the next-release milestone Jun 20, 2024
@bduranleau-nr bduranleau-nr force-pushed the fix/mongodb-before-after branch from a163988 to eaff30f Compare June 20, 2024 16:55
lavarou
lavarou previously approved these changes Jun 21, 2024
Comment thread agent/lib_mongodb.c Outdated
Comment thread agent/lib_mongodb.c Outdated
Comment thread agent/lib_mongodb.c

@zsistla zsistla left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job getting this working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants