fix(NewRelicContextFormatter): add cause and context to stack traces#1266
Merged
TimPansino merged 11 commits intonewrelic:mainfrom Jan 29, 2025
sweco:main
Merged
fix(NewRelicContextFormatter): add cause and context to stack traces#1266TimPansino merged 11 commits intonewrelic:mainfrom sweco:main
TimPansino merged 11 commits intonewrelic:mainfrom
sweco:main
Conversation
|
|
Contributor
|
We'll give this a review after the US holiday season is over, we're going to avoid the risk of changing anyone's logs during this time period. |
TimPansino
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
NewRelicContextFormatterlogs stack traces without causes which makes many errors hard to debug.Let's take a look at the following code:
Before the PR, the exception message looked as follows:
After the PR, it shows more details on the first cause:
Related Github Issue
No Github issue created.
Testing
Tests were updated to test a particular case where exception has a cause.