Merged
Conversation
We have the allowlist functionality now that is faster.
default, adaptive, always_on, always_off are now available for use when a trace is root, remote_parent_sampled or remote_parent_not_sampled. default is first in the case list because it is the most common. I predict adaptive will be far less common than always_on or always_off, so I put it last for a slight performance benefit.
Move validation to a separate module and use a transform to call those methods. Remove ratio validation checks and fallbacks in Transaction, TraceContext, and DistributedTracing.
Since both DistributedTracing#set_priority_and_sampled_newrelic_header and TraceContext#set_priority_and_sampled are included in the Transaction class and the methods ended up being identical, we can define it in only one spot.
Setting it to all or nothing isn't compatible with the spec
Now the trace ratio sampling logic lives in one method
OpenTelemetry stores their trace IDs as binary strings: "\xAB\xCD\xEF\x01#Eg\x89" We keep ours as alphanumeric strings (ex: "abcdef0123456789") Rather than coerce every trace ID into a binary string, we can use Integer to translate our guids into the same value as the unpacked binary by translating them into base 16.
kafka needs to try harder
* The SqlSampler#notice_sql API will be removed in the next major version * The Datastores.notice_sql API is its replacement. It has two unused arguments that will be removed in the next major version.
Co-authored-by: Hannah Ramadan <76922290+hannahramadan@users.noreply.github.com>
Co-authored-by: Hannah Ramadan <76922290+hannahramadan@users.noreply.github.com>
The method is used to determine priorities outside of the adaptive sampler and is the legacy, default priority
The second argument, elapsed, has not been in use for the past 9 years. Similar to Datastores#notice_sql, deprecate the unused argument and give it a default value.
…/newrelic/newrelic-ruby-agent into trace-ratio-with-config-refactor
The proc for Datastores#wrap will no longer expect the second (scoped metric name) and third (elapsed) arguments in a future major release. These args will no longer part of the Datastores#notice_sql method.
Add Root sampler, Trace ID ratio based sampler options
Deprecate unused arg from Datastores.notice_statement, Datastores.wrap
Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.267.0 to 1.268.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@d5126b9...8aeb6ff) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-version: 1.268.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2.4.1 to 2.5.0. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@6da8fa9...a06a81a) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-version: 2.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…/setup-ruby-1.268.0 Bump ruby/setup-ruby from 1.267.0 to 1.268.0
…props/action-gh-release-2.5.0 Bump softprops/action-gh-release from 2.4.1 to 2.5.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 6.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@08c6903...1af3b93) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ons/checkout-6.0.0 Bump actions/checkout from 5.0.0 to 6.0.0
…id-agent Add config, supportability metrics for OTel traces
We need to make some breaking changes to the existing strategies, so we're going to postpone announcement and documentation until 10.0
Disable new samplers
Prerelease 9.24.0-pre
kaylareopelle
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR for 9.24.0 release