Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Assign all attributes on internal spans to segment #3000

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

bizob2828
Copy link
Member

Description

This PR updates span processor to reconcile attributes on internal spans. I also realized we're assigning the wrong time slice metrics recorder for internal spans. It should be the generic recorder.

Related Issues

Closes #2998

@bizob2828 bizob2828 force-pushed the reconcile-internal branch from 1030d37 to d37ef1e Compare March 19, 2025 20:41
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (b808e00) to head (d37ef1e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3000      +/-   ##
==========================================
- Coverage   97.52%   97.48%   -0.05%     
==========================================
  Files         323      323              
  Lines       49234    49236       +2     
==========================================
- Hits        48017    47997      -20     
- Misses       1217     1239      +22     
Flag Coverage Δ
integration-tests-cjs-18.x 72.04% <25.00%> (-0.01%) ⬇️
integration-tests-cjs-20.x 72.02% <25.00%> (-0.02%) ⬇️
integration-tests-cjs-22.x 72.25% <25.00%> (-0.01%) ⬇️
integration-tests-esm-18.x 49.84% <25.00%> (-0.01%) ⬇️
integration-tests-esm-20.x 49.84% <25.00%> (-0.01%) ⬇️
integration-tests-esm-22.x 49.90% <25.00%> (-0.01%) ⬇️
unit-tests-18.x 89.05% <50.00%> (-0.01%) ⬇️
unit-tests-20.x 89.05% <50.00%> (-0.01%) ⬇️
unit-tests-22.x 89.06% <50.00%> (-0.01%) ⬇️
versioned-tests-18.x 79.85% <100.00%> (-0.18%) ⬇️
versioned-tests-20.x 79.86% <100.00%> (-0.18%) ⬇️
versioned-tests-22.x 79.87% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bizob2828 bizob2828 merged commit 5403018 into newrelic:main Mar 19, 2025
26 of 27 checks passed
@bizob2828 bizob2828 deleted the reconcile-internal branch March 19, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Handle attribute reconciliation when an internal span ends
2 participants