Skip to content

Conversation

@amychisholm03
Copy link
Contributor

@amychisholm03 amychisholm03 commented Dec 11, 2025

Description

To facilitate establishing relationships between fleet control agent entities and the related APM service that an agent creates, the entity guid will now be part of the health file written out for agent control. Note that this new field MUST be the first entry in the health file.

From the spec:
"| entity_guid | string | The primary entity GUID received in the connect response. This MUST be the first field in the health file |

This format is based on the OpAMP protocol. The entity
GUID is the first field in the file so as not to break the OpAmp compatibility in the remainder of the file.

For a health file written out prior to the entity GUID being available, the agent should include the entity_guid key with an empty value."

How to Test

npm run unit

Related Issues

Closes #3591

@amychisholm03 amychisholm03 force-pushed the NR-3591/entity-guid-ac-health branch from 93e9f85 to c28e5e4 Compare December 11, 2025 22:17
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.93%. Comparing base (74777d5) to head (0a06886).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
lib/health-reporter.js 47.82% 12 Missing ⚠️
lib/collector/api.js 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (74777d5) and HEAD (0a06886). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (74777d5) HEAD (0a06886)
unit-tests-24.x 1 0
unit-tests-20.x 1 0
unit-tests-22.x 1 0
integration-tests-cjs-20.x 1 0
integration-tests-cjs-24.x 1 0
integration-tests-cjs-22.x 1 0
integration-tests-esm-20.x 1 0
versioned-tests-24.x 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3594       +/-   ##
===========================================
- Coverage   97.81%   80.93%   -16.88%     
===========================================
  Files         434      424       -10     
  Lines       56941    55768     -1173     
  Branches        1        1               
===========================================
- Hits        55698    45137    -10561     
- Misses       1243    10631     +9388     
Flag Coverage Δ
integration-tests-cjs-20.x ?
integration-tests-cjs-22.x ?
integration-tests-cjs-24.x ?
integration-tests-esm-20.x ?
unit-tests-20.x ?
unit-tests-22.x ?
unit-tests-24.x ?
versioned-tests-22.x 80.93% <42.30%> (-0.32%) ⬇️
versioned-tests-24.x ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amychisholm03 amychisholm03 marked this pull request as ready for review December 15, 2025 16:07
@amychisholm03 amychisholm03 force-pushed the NR-3591/entity-guid-ac-health branch from c134b43 to 0a06886 Compare December 15, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs PR Review

Development

Successfully merging this pull request may close these issues.

Add entity_guid to agent control health file

1 participant