chore: Update @langchain/core version for langchain-openai tests#3763
Open
amychisholm03 wants to merge 1 commit intonewrelic:mainfrom
Open
chore: Update @langchain/core version for langchain-openai tests#3763amychisholm03 wants to merge 1 commit intonewrelic:mainfrom
@langchain/core version for langchain-openai tests#3763amychisholm03 wants to merge 1 commit intonewrelic:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3763 +/- ##
==========================================
- Coverage 97.89% 97.71% -0.18%
==========================================
Files 454 453 -1
Lines 58749 58636 -113
Branches 1 1
==========================================
- Hits 57512 57297 -215
- Misses 1237 1339 +102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Root cause:
@langchain/openai@1.2.8added an import ofContextOverflowErrorfrom@langchain/core/errors(in utils/client.js), but the./errorssubpath was only added to@langchain/corestarting in v1.1.18. The peer dependency declared by@langchain/openaiwas ^1.0.0, which was too loose and allows npm to resolve an older@langchain/corethat doesn't have this export.Fix: Bumped the @langchain/core minimum from >=1.0.0 to >=1.1.18. This ensures the versioned test runner won't create combinations where
@langchain/openai@>=1.2.8is paired with an incompatible@langchain/core.How to Test
Related Issues
CI fix.