refactor: Updated the reparenting logic for compact mode of partial traces to assign parent id to entry span#3768
Merged
bizob2828 merged 1 commit intonewrelic:mainfrom Feb 18, 2026
Conversation
…races to assign parent id to entry span
svetlanabrennan
approved these changes
Feb 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3768 +/- ##
==========================================
- Coverage 97.89% 97.71% -0.18%
==========================================
Files 454 453 -1
Lines 58749 58639 -110
Branches 1 1
==========================================
- Hits 57512 57300 -212
- Misses 1237 1339 +102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We didn't implement compact reparenting to the spec. For all retained spans, the parent id should be the entry span.
Our logic was only reparenting to entry span if it was an exit span.
This PR also updates the cross agent tests to exhibit this behavior and cleaned up the
assertParentIdto make more sense if it fails.How to Test
Related Issues
Closes #3764