Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple workload issues in sidebar #509

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix: multiple workload issues in sidebar #509

merged 1 commit into from
Mar 6, 2025

Conversation

amit-y
Copy link
Contributor

@amit-y amit-y commented Mar 6, 2025

Closes #502

  • fixes issues from feat: refactor workload status calculation and display of incidents #504
    • violations not showing when not in playback mode
    • violations were on props change in certain situations
  • adding a loading indicator when violations from workload entities are being fetched in the sidebar
  • refactor query that fetches violations for workloads entities to fetch only required data

aso1124
aso1124 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@aso1124 aso1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amit-y amit-y merged commit 8e053fa into main Mar 6, 2025
12 checks passed
@amit-y amit-y deleted the update-workloads-status branch March 6, 2025 21:22
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aso1124 aso1124 aso1124 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workload Status Updates
3 participants
@amit-y @nr-opensource-bot @aso1124