Skip to content

Comments

test: fallback to null if chart version not defined#381

Merged
kb-newrelic merged 2 commits intomainfrom
kbauer/identify-nightly-via-testkey-instead-of-hostname-2
Sep 5, 2025
Merged

test: fallback to null if chart version not defined#381
kb-newrelic merged 2 commits intomainfrom
kbauer/identify-nightly-via-testkey-instead-of-hostname-2

Conversation

@kb-newrelic
Copy link
Contributor

@kb-newrelic kb-newrelic commented Sep 5, 2025

Summary

  • Fixes test: use testKey instead of host.name for nightly #378 which doesn't account for terraform erroring instead of using null for an undefined field of an object. The chart version is no defined for the host distro as it's using the local nr-backend chart which can't be used in a versioned way as its not published anywhere.
  • Increasing nightly test timeout/retries as it failed for an ec2-based test. The EC2 got replaced in the deploy step before and expected telemetry was present during debugging, so test probably ran before EC2 fully spun out and started reporting. Second run (including increased timeout passed) - it might have succeeded without as well but this should increase the chance of it passing on the first try.

@kb-newrelic kb-newrelic requested a review from a team as a code owner September 5, 2025 19:03
Copy link
Contributor

@mailo-nr mailo-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kb-newrelic kb-newrelic merged commit eb20dd4 into main Sep 5, 2025
28 checks passed
@kb-newrelic kb-newrelic deleted the kbauer/identify-nightly-via-testkey-instead-of-hostname-2 branch September 5, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants