ci: add fips to release draft and publish#406
Merged
Conversation
kb-newrelic
reviewed
Oct 2, 2025
| - name: Verify build | ||
| run: make ci DISTRIBUTIONS=${{ matrix.distribution }} | ||
|
|
||
| - name: Install cross-compilation toolchain |
Contributor
There was a problem hiding this comment.
Wondering if we should think about maintaining a runner image that bundles all dependencies instead of having to copy&pasta it everywhere (potentially running into drift). Not relevant for this PR, just curious what your thoughts are.
kb-newrelic
reviewed
Oct 2, 2025
| args: --clean --skip=announce --timeout 2h | ||
| workdir: distributions/${{ matrix.distribution }} | ||
|
|
||
| - name: Build FIPS binaries & packages with GoReleaser |
Contributor
There was a problem hiding this comment.
As this steps reuses the dist dir, should we clean it up after the non-fips build?
Contributor
There was a problem hiding this comment.
Another options would be to override the dist folder for fips
Contributor
Author
There was a problem hiding this comment.
the --clean flag should empty the folder, the only reason i might advocate for keeping the same folder is to have a cleaner path to merging the goreleaser configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds build/publish step for fips on draft and copies the manifest on on publish