Conversation
.github/workflows/ci-base.yaml
Outdated
There was a problem hiding this comment.
Trying a hard stop if metadata isn't found in the cached build, following this discussion on the original draft.
.github/workflows/ci-base.yaml
Outdated
There was a problem hiding this comment.
Given that CI only uses a single arch, is checking for all binaries like this overkill?
If so, we may only need to check for metadata.json here - We do a separate check for the specific arch's binary in a later step.
.github/workflows/ci-base.yaml
Outdated
There was a problem hiding this comment.
I think runner.temp might handle this already: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#runner-context
There was a problem hiding this comment.
That sounds much nicer, I'll look into that, thank you!
.github/workflows/ci-base.yaml
Outdated
There was a problem hiding this comment.
What are your thoughts on moving this to its own bash script? Since it's just a sanity check if might make sense to not clutter the workflow.
There was a problem hiding this comment.
Putting it in its own bash script sounds much better to me! We might be able to re-use it for other workflows in the future that way.
I can do the same for the Verify source files exist step too, since it's a similar sanity check.
Summary
Validation