Skip to content

feat: Add more brokertopic and controller metrics (NR-402726)#337

Open
dsankaraganti wants to merge 3 commits intonewrelic:masterfrom
dsankaraganti:master
Open

feat: Add more brokertopic and controller metrics (NR-402726)#337
dsankaraganti wants to merge 3 commits intonewrelic:masterfrom
dsankaraganti:master

Conversation

@dsankaraganti
Copy link
Copy Markdown

@dsankaraganti dsankaraganti commented Apr 28, 2025

Introducing new config ENABLE_BROKER_TOPIC_METRICS_V2 in nri-kafka

To enable processing additional metrics. Below are metric details

  • Metric: kafka.server:type=BrokerTopicMetrics,name=BytesOutPerSec,topic=* topic level
  • Metric: kafka.server:type=BrokerTopicMetrics,name=MessagesInPerSec,topic=* topic level
  • Metric: kafka.controller:type=KafkaController,name=ActiveControllerCount broker level
  • Metric: kafka.controller:type=KafkaController,name=GlobalPartitionCount broker level

Adding fields needed to index topic entity
Including topic.name to topic inventory to index the topic entity

Testing

Integration tests:
image

Unit tests:
image

Reported Data

Data reported to NR from local test app:

  1. ActiveControllerCount & GlobalPartitionCount -> https://staging.onenr.io/0oR80ZKOeRG
  2. BytesOutPerSec -> https://staging.onenr.io/00jl0XW8YjW
  3. MessagesInPerSec -> https://staging.onenr.io/0KQXKVL51ja

@dsankaraganti dsankaraganti requested a review from a team as a code owner April 28, 2025 08:55
@satya-nr
Copy link
Copy Markdown

Hi, can you please put the test results here.

satya-nr
satya-nr previously approved these changes Apr 28, 2025
Copy link
Copy Markdown

@satya-nr satya-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@satya-nr satya-nr dismissed their stale review April 28, 2025 11:59

Currently discussing with our team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants