Skip to content

fix bug with windows images, feat support for windows only nodes#1465

Draft
danielstokes wants to merge 1 commit into
mainfrom
fix-win-tag
Draft

fix bug with windows images, feat support for windows only nodes#1465
danielstokes wants to merge 1 commit into
mainfrom
fix-win-tag

Conversation

@danielstokes

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests


# -- Enable Linux node monitoring.
# @default -- `true`
enableLinux: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this? it's only linked to the daemonset, and it may not be clear to the user that the other linux scrapers are going to deploy regardless.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. i'm not sure how or why, but i guess we have at least 1 customer that had this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants