feat(kubelet): Create an agent container in the kubelet pod only#944
Open
tormodmacleod wants to merge 5 commits intonewrelic:mainfrom
Open
feat(kubelet): Create an agent container in the kubelet pod only#944tormodmacleod wants to merge 5 commits intonewrelic:mainfrom
tormodmacleod wants to merge 5 commits intonewrelic:mainfrom
Conversation
enabling agentOnly mode should create only an 'agent' container within the kubelet pod
rather than from a daemonset
do not create or mount this configmap. it is only used by the kubelet container
naming a pod as 'kubelet' kind of suggests that it's a daemonset. if we're running in agentOnly mode then there is only a single pod containing an infrastructure agent container. renaming this so as not to mislead or confuse the user
include some information in values.yaml as to what agentOnly controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This provides the user with the ability to create only a single pod containing an infrastructure agent container when combined with
kubelet.enabled == falseandksm.enabled == false.This is useful when you already have your kubernetes infrastructure monitored by newrelic at the infrastructure layer and you want to retrieve the length of some redis keys which are relevant at the application layer.
For more details of the motivation for this change please see #943
Fixes: #943
Type of change
Checklist:
I tested this locally and everything works as it ought to