Feat : Query Performance monitoring tech debt #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tharun0064
commented
Feb 21, 2025
tharun0064
commented
- Removed System queries and OHI queries filter
- Added more unit test cases
- Added QueryMonitoringOnly flag to enable only query monitoring feature
- usage of marshal metrics
- common function which is reused to fetch metrics
- return parameter which were expected datatype instead of nil
1. Removed System queries and OHI queries filter 2. Added more unit test cases 3. Added QueryMonitoringOnly flag to enable only query monitoring feature 4. usage of marshal metrics 5. common function which is reused to fetch metrics 6. return parameter which were expected datatype instead of nil
* add case-insensitive like operation
* exclude explain queries in wait events
sairaj18
reviewed
Mar 17, 2025
| } | ||
| // For PostgreSQL versions 13 and 12, anonymization of queries does not occur for blocking sessions, so it's necessary to explicitly anonymize them. |
There was a problem hiding this comment.
could add this comment back as it would be helpful while refering in future.
sairaj18
reviewed
Mar 17, 2025
| } | ||
| } | ||
| } | ||
|
|
||
| // IngestMetric is a util by which we publish data in batches .Reason for this is to avoid publishing large data in one go and its a limitation for NewRelic. | ||
| func IngestMetric(metricList []interface{}, eventName string, pgIntegration *integration.Integration, cp *commonparameters.CommonParameters) error { |
There was a problem hiding this comment.
unit tests for testing when this func errors out are missing.
sairaj18
reviewed
Mar 17, 2025
| enabledExtensions := map[string]bool{"pg_wait_sampling": false} | ||
| err := PopulateWaitEventMetrics(conn, pgIntegration, cp, enabledExtensions) | ||
| assert.Equal(t, err, commonutils.ErrNotEligible) | ||
| assert.NoError(t, mock.ExpectationsWereMet()) |
There was a problem hiding this comment.
why do we need this, is checking assert.Equal(t, err, commonutils.ErrNotEligible) not enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.