Skip to content

feat: NR-469064 Implement exclude_matching_entities filter in nri-winservice#221

Merged
nravada merged 4 commits intomasterfrom
NR-469064
Oct 14, 2025
Merged

feat: NR-469064 Implement exclude_matching_entities filter in nri-winservice#221
nravada merged 4 commits intomasterfrom
NR-469064

Conversation

@nravada
Copy link
Contributor

@nravada nravada commented Oct 10, 2025

…service

Description

Please include a summary of the change and which issue is fixed or feature is introduced.

Checklist:

  • I checked that Licenses of new dependencies is compliant with our guidelines

  • I have performed a self-review of my own code

  • I have added comments in my code to clarify it

  • I have updated the documentation accordingly

  • I have added tests that show my fix/feature works

  • I cleaned the commit history, and they are following the conventional commits pattern, es:

    `type(scope): what I have changed`
    

@nravada nravada requested a review from a team as a code owner October 10, 2025 14:41
@nravada
Copy link
Contributor Author

nravada commented Oct 10, 2025

Tested scenarios for newly added exclude_matching_entities config parameter are available in the below document:
https://docs.google.com/document/d/1HMTgaQeF4cRgdw6fI9qruGgK2VIfZgX9OneVvn-vXMQ/edit?tab=t.0

@abhishuraina
Copy link
Contributor

Can update the integration tests as well.

@nravada
Copy link
Contributor Author

nravada commented Oct 13, 2025

Integration test results:
go test -v ./test/ -tags=integration
=== RUN TestIntegration
[DEBUG] integration version: v0.0.0 commit: f10a974
[DEBUG] pattern added regex: ^*$
[DEBUG] pattern added regex: ^ServiceNameToBeIncluded$
[DEBUG] pattern added regex: ^ServiceNameToBeExcluded$
[DEBUG] pattern added regex: ^newrelic-infra$
[DEBUG] pattern added regex: ^(Themes)$
[DEBUG] running with scrape interval: 15s
[DEBUG] Running exporter
[DEBUG] Running Integration
[DEBUG] Sending heartBeat
[DEBUG] Sending heartBeat
[DEBUG] Sending heartBeat
[DEBUG] Scraping and publishing metrics
[DEBUG] Performing HTTP request against: http://127.0.0.1:9182/metrics
[DEBUG] HTTP request performed - Status: 200 OK, total time taken to perform request: 93.352ms
[DEBUG] Parsing body of the exporter answer
[DEBUG] Body of the exporter answer parsed
[DEBUG] Metrics scraped, MetricsByFamily found: 48, time elapsed: 108.5627ms
[DEBUG] all metrics have value 0 for: windows_service_process
[DEBUG] Metrics processed, entities found: 261, time elapsed: 112.4013ms
[DEBUG] Metrics published
[DEBUG] Sending heartBeat
[DEBUG] Sending heartBeat
[DEBUG] Sending heartBeat
[DEBUG] Scraping and publishing metrics
[DEBUG] Performing HTTP request against: http://127.0.0.1:9182/metrics
[DEBUG] HTTP request performed - Status: 200 OK, total time taken to perform request: 34.9338ms
[DEBUG] Parsing body of the exporter answer
[DEBUG] Body of the exporter answer parsed
[DEBUG] Metrics scraped, MetricsByFamily found: 48, time elapsed: 44.0734ms
[DEBUG] all metrics have value 0 for: windows_service_process
[DEBUG] Metrics processed, entities found: 261, time elapsed: 45.4317ms
[DEBUG] Metrics published
[DEBUG] Sending heartBeat
[DEBUG] Sending heartBeat
[DEBUG] Sending heartBeat
[DEBUG] Scraping and publishing metrics
[DEBUG] Performing HTTP request against: http://127.0.0.1:9182/metrics
[DEBUG] HTTP request performed - Status: 200 OK, total time taken to perform request: 38.1219ms
[DEBUG] Parsing body of the exporter answer
[DEBUG] Body of the exporter answer parsed
[DEBUG] Metrics scraped, MetricsByFamily found: 48, time elapsed: 47.2449ms
[DEBUG] all metrics have value 0 for: windows_service_process
[DEBUG] Metrics processed, entities found: 261, time elapsed: 48.5432ms
[DEBUG] Metrics published
[DEBUG] Sending heartBeat
[DEBUG] Sending heartBeat

--- PASS: TestIntegration (60.60s)
PASS
ok github.com/newrelic/nri-winservices/test 61.183s
PS C:\Users\nravada\newrelic\nri-winservices>

Copy link

@muruganishekar muruganishekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nravada nravada merged commit 14cf858 into master Oct 14, 2025
8 checks passed
@nravada nravada deleted the NR-469064 branch October 14, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments