security(release): declare least-privilege permissions on the release workflow#1396
Merged
Merged
Conversation
… workflow Fixes CodeQL alerts #61 and #43 (actions/missing-workflow-permissions, medium severity) on .github/workflows/release.yml. Adopts the workflow-level default already used by cleanup-jp.yml and nonregression-jp.yml — `permissions: contents: read` at the top — and overrides individually where a job legitimately needs more: - build: contents: write (actions/create-release@v1 publishes the Release) - zip-recipes: contents: write (actions/upload-release-asset attaches recipes.zip) - commit-release-notes: no override; falls back to workflow-level contents: read. Its push already uses secrets.RELEASE_TOKEN (a PAT), not the default GITHUB_TOKEN, so GITHUB_TOKEN doesn't need write on this job. This tightens up the earlier grant that was left over from when the job used GITHUB_TOKEN for the push (before #1395). No behavior change — the workflow's actual runtime permissions are unchanged for the two jobs that need write, and correctly downgraded for the one that doesn't.
nr-developer-toolkit
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CodeQL alerts #61 and #43 — both are
actions/missing-workflow-permissions(medium severity) against.github/workflows/release.yml.Adopts the workflow-level default already used by
cleanup-jp.ymlandnonregression-jp.yml:…and overrides individually where a job legitimately needs more:
buildcontents: writeactions/create-release@v1publishes the Releasezip-recipescontents: writeactions/upload-release-assetattachesrecipes.zipcommit-release-notescontents: read)secrets.RELEASE_TOKEN(PAT), notGITHUB_TOKEN— this also tightens a leftovercontents: writefrom before #1395 landedTest plan
Create Releasestill creates release,zip-recipesstill uploads,commit-release-notesstill pushes to main).