Skip to content

test(ci): DO NOT MERGE - run E2E on the Ruby 3.4.13 deployer image - #1478

Closed
Nandu-pns wants to merge 1 commit into
mainfrom
test/deployer-ruby34-image
Closed

Nandu-pns wants to merge 1 commit into
mainfrom
test/deployer-ruby34-image

Conversation

@Nandu-pns

Copy link
Copy Markdown
Contributor

Do not merge. This is a temporary test PR. It will be closed once the run finishes.

Purpose

Run open-install-library's E2E tests against the deployer image from newrelic-experimental/deployer PR 34, which moves the image from Ruby 2.7.4 to Ruby 3.4.13 (Ruby2Shell, CVE-2026-132825), before that image is published as newrelic/deployer:latest.

The deployer repo's own cloud UATs can't confirm a real deployment right now (its test accounts lack permissions), so this checks the full path OIL uses: provision a host, deploy a service, run newrelic install, validate, then tear down.

What this PR changes (temporary)

  • validation.yml, "Pull Deployer image" step: builds the image from the PR branch instead of pulling latest:
    docker build -t newrelic/deployer:latest "https://github.com/newrelic-experimental/deployer.git#fix/ruby-3.4-base-image"
    
    Later steps keep using the newrelic/deployer:latest tag, so they run the new image. Nothing is pushed to Docker Hub, and other OIL runs keep using the current latest.
  • Three test definitions get a trailing newline only, so PR validation picks them up. All three passed in today's US regression run on the current image:
    • infra-agent/ubuntu24-infra.json: infra agent install (install role)
    • logging/amazonlinux2023.json: targeted install (-n logs-integration)
    • ohi/linux/rabbitmq-debian.json: deploys a service (RabbitMQ) on the host first, then installs

What to look for

  • The "Pull Deployer image" step prints ruby 3.4.13
  • All three tests pass provision → install → validation → teardown, the same as on the current image

Temporarily builds the deployer image from newrelic-experimental/deployer PR 34 (branch fix/ruby-3.4-base-image) instead of pulling newrelic/deployer:latest, and touches three test definitions so PR validation runs them against it.
@Nandu-pns

Copy link
Copy Markdown
Contributor Author

Closing as planned. This was a temporary test PR and isn't meant to be merged.

All three E2E tests passed on the deployer image built from newrelic-experimental/deployer PR 34 (Ruby 3.4.13, 72cffaa): infra-agent/ubuntu24-infra.json, logging/amazonlinux2023.json and ohi/linux/rabbitmq-debian.json. Each went through provision → install → validation → teardown. A re-run of the logs test finished in 353s, compared with 386s on the current image, so the slower first run was just timing variance.

PR 34 is merged and the new newrelic/deployer:latest is being published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant