Repository navigation
Conversation
Temporarily builds the deployer image from newrelic-experimental/deployer PR 34 (branch fix/ruby-3.4-base-image) instead of pulling newrelic/deployer:latest, and touches three test definitions so PR validation runs them against it.
Merged
7 tasks done
Contributor
Author
|
Closing as planned. This was a temporary test PR and isn't meant to be merged. All three E2E tests passed on the deployer image built from newrelic-experimental/deployer PR 34 (Ruby 3.4.13, PR 34 is merged and the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Run open-install-library's E2E tests against the deployer image from newrelic-experimental/deployer PR 34, which moves the image from Ruby 2.7.4 to Ruby 3.4.13 (Ruby2Shell, CVE-2026-132825), before that image is published as
newrelic/deployer:latest.The deployer repo's own cloud UATs can't confirm a real deployment right now (its test accounts lack permissions), so this checks the full path OIL uses: provision a host, deploy a service, run
newrelic install, validate, then tear down.What this PR changes (temporary)
validation.yml, "Pull Deployer image" step: builds the image from the PR branch instead of pullinglatest:newrelic/deployer:latesttag, so they run the new image. Nothing is pushed to Docker Hub, and other OIL runs keep using the currentlatest.infra-agent/ubuntu24-infra.json: infra agent install (installrole)logging/amazonlinux2023.json: targeted install (-n logs-integration)ohi/linux/rabbitmq-debian.json: deploys a service (RabbitMQ) on the host first, then installsWhat to look for
ruby 3.4.13