Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nrql_alert_condition.html.markdown): fix example #2793

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

mvdiener
Copy link
Contributor

@mvdiener mvdiener commented Jan 17, 2025

Description

Update the docs to use a valid example.

Fixes #
Trying to use the previous example gives errors about invalid Handlebars. This updates the docs example to a valid Handlebars statement.

Type of change

  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • I have made corresponding changes to the documentation

How to test this change?

Only docs changes.

Update the docs to use a valid example.
@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.06%. Comparing base (92361de) to head (77ecd38).
Report is 132 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2793      +/-   ##
==========================================
- Coverage   32.82%   31.06%   -1.76%     
==========================================
  Files          98      102       +4     
  Lines       26884    27602     +718     
==========================================
- Hits         8824     8574     -250     
- Misses      17902    18858     +956     
- Partials      158      170      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinay-newrelic
Copy link
Contributor

Approved

@rpaliwal1997 rpaliwal1997 merged commit 5114dc1 into newrelic:main Mar 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants