-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nr 379962 support ms teams destination #2842
base: main
Are you sure you want to change the base?
Nr 379962 support ms teams destination #2842
Conversation
go.mod
Outdated
@@ -20,7 +20,7 @@ require ( | |||
github.com/davecgh/go-spew v1.1.1 // indirect | |||
github.com/fatih/color v1.16.0 // indirect | |||
github.com/golang/protobuf v1.5.3 // indirect | |||
github.com/google/go-cmp v0.5.9 // indirect | |||
github.com/google/go-cmp v0.6.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amandeepmalik can you please help me to understand the need to update this dependency version. Is this required for this changes or are you facing any issue with the previous version??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I did not update this manually and even the go.sum file, this may have got updated during when I executed 'make compile' command but I'm not really sure about it, do you want me to revert both these files?
Also, I have a question, since client-go is updated now, do I have to update it's version in go.mod?
Description
Please include a summary of the change and which issue is fixed (if relevant).
support ms teams destination via TF
Type of change
Please delete options that are not relevant.
Checklist:
Please delete options that are not relevant.
How to test this change?
Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc